Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows 8 and windows 7 testing for PRs in a reduced way #36096

Merged
merged 1 commit into from
May 8, 2020

Conversation

safern
Copy link
Member

@safern safern commented May 8, 2020

We got more cores on Windows 8 and Windows 7, I don't think enough to the amount of work we where sending previously, but this gets us some coverage on both queues. Windows7 x86 and Windows8.1 x64.

cc: @dotnet/runtime-infrastructure

FYI: @MattGal

@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern safern force-pushed the AddWindows7and8ToPrs branch from 7693f66 to 793bf00 Compare May 8, 2020 16:39
@safern
Copy link
Member Author

safern commented May 8, 2020

Can I get a review here? Would like to merge this to get coverage and protect Rolling builds by running these OSs in PRs as well.

@safern
Copy link
Member Author

safern commented May 8, 2020

Test failures are unrelated: #36135 and #29642

@safern safern merged commit 863d458 into dotnet:master May 8, 2020
@safern safern deleted the AddWindows7and8ToPrs branch May 8, 2020 19:07
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants