Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove superflous CheckReleased call which will slow down Event Log R…" #36143

Merged
merged 1 commit into from
May 8, 2020
Merged

Revert "Remove superflous CheckReleased call which will slow down Event Log R…" #36143

merged 1 commit into from
May 8, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented May 8, 2020

Reverts #35911

@tarekgh
Revert "Remove superflous CheckReleased call which will slow down Eve…
5790b1c 
…nt Log Reading up to 20x times. (#35911)"

This reverts commit 4602a61.
@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented May 8, 2020

Tagging subscribers to this area: @tommcdon, @krwq
Notify danmosemsft if you want to be subscribed.

This was referenced May 8, 2020
Open
Closed
safern
safern approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarekgh

@tarekgh tarekgh merged commit ca8c9de into master May 8, 2020
@jkotas jkotas deleted the revert-35911-eventlogperf_fix branch May 9, 2020 02:23
tarekgh added a commit that referenced this pull request May 10, 2020
@tarekgh
Revert "Revert "Remove superflous CheckReleased call which will slow …
dd0e212 
…down Event Log Reading up to 20x times. (#35911)" (#36143)"

This reverts commit ca8c9de.
@tarekgh tarekgh mentioned this pull request May 10, 2020
Merged
tarekgh added a commit that referenced this pull request May 11, 2020
@tarekgh
Revert "Revert "Remove superflous CheckReleased call which will slow …
35eb262 
…down Event Log Reading up to 20x times. (#35911)" (#36143)" (#36188)

This reverts commit ca8c9de.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekgh @safern @Dotnet-GitSync-Bot