-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux arm/arm64 libraries checked coreclr test runs #36910
Conversation
Tagging subscribers to this area: @ViktorHofer |
Lets add one runtime at a time in case we hit capacity issues. |
Makes sense. |
I haven't actually been working on the libraries tests for mono, only the runtime tests, so I'm not sure if there is a reason they have not been enabled on arm64, although I think we will eventually want to. @EgorBo @steveisok Do you know? |
This is something we want to enable for Mono runtime too. This is being tracked via the first table in #33381 @steveisok is tracking that work. |
@safern looks like there is a test that should be disabled? |
Yeah. I'll update the PR. Also I think we should also include alpine_arm64, what do you think? |
|
We should definitely include an Alpine leg in PR runs if possible. We would have caught the issue with Alpine test runs using the dotnet CLI if we had an alpine run. |
Would this have been caught with alpine arm64 runtime tests? |
Yeah. |
Actually, yes, that's where they would have been caught. |
That seems to be the larger issue then |
6ff7c64
to
0101947
Compare
@jashook looks good? In case this is green I'd like to merge. |
Issue: dotnet#36910 See if this fails again in the CI
We should be running libraries tests on checked coreclr in arm/arm64 -- if we want to add these for mono as well, I'll let @naricc and @SamMonoRT to confirm... I can put up a follow up PR if needed.
This depends on: #36909
For more details: #36909 (comment)
cc: @dotnet/runtime-infrastructure @sdmaclea