Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange tfms for intellisense in vscode and visual studio #37027

Merged
merged 1 commit into from
May 27, 2020
Merged

Rearrange tfms for intellisense in vscode and visual studio #37027

merged 1 commit into from
May 27, 2020

Conversation

Anipik
Copy link
Contributor

@Anipik Anipik commented May 26, 2020

Fixes #36799

The intellisense always picks up the first tfm in tfms to resolve the references, so the first one needs to be netcoreapp-*

@ghost
Copy link

ghost commented May 26, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ViktorHofer
Copy link
Member

so the first one needs to be netcoreapp-*

What about netstandard-only projects?

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we will have to live with? Like we use to do with, /t:UpdateVSConfigurations? If so, is there a way we can improve/fix this in a better way?

@Anipik
Copy link
Contributor Author

Anipik commented May 26, 2020

What about netstandard-only projects?

The intellisense will work if the ref folder is populated with the correct reference assemblies.

Is this something we will have to live with? Like we use to do with, /t:UpdateVSConfigurations? If so, is there a way we can improve/fix this in a better way?

We can have designTimeBuild protection on ci which can help us catch these errors before they are introduced. I have an issue tracking that.
We can write a msbuild task to check that none of our quirks are violated.
We have a couple of them (Having all the tfm derived properties in the second property group).

@Anipik Anipik merged commit 08e0445 into dotnet:master May 27, 2020
@Anipik Anipik deleted the dtb branch May 27, 2020 00:43
@ViktorHofer
Copy link
Member

Got it thanks. Then I don't think we need any protection for this as I'm currently working on getting rid of the upfront restore necessity hence the order of tfms shouldn't matter going forward.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DesignTimeBuilds are partially broken for some projects.
4 participants