Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity Ids and Context to log scopes #37092

Merged
merged 5 commits into from
May 29, 2020

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented May 27, 2020

Fixes #34305

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tarekgh
Copy link
Member Author

tarekgh commented May 27, 2020

CC @shirhatti

@tarekgh
Copy link
Member Author

tarekgh commented May 29, 2020

The failure of runtime (Libraries Test Run release mono Linux x64 Debug) is tracked by the issue #37186

@tarekgh tarekgh merged commit d144af4 into dotnet:master May 29, 2020
@tarekgh tarekgh deleted the LoggingWithActivityId branch June 22, 2020 16:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add activity Ids and Context to all logs
3 participants