Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected and fixed comparison for System.Reflection.MetadataLoadContext #37204

Closed
wants to merge 1 commit into from
Closed

Corrected and fixed comparison for System.Reflection.MetadataLoadContext #37204

wants to merge 1 commit into from

Conversation

ShreyasJejurkar
Copy link
Contributor

This PR will add fix to System.Reflection.MetadataLoadContext
Corresponding issue - #28046

@ShreyasJejurkar ShreyasJejurkar mentioned this pull request May 30, 2020
Closed
@jkotas
Copy link
Member

jkotas commented May 30, 2020

Could you please also add a test case for this?

@ShreyasJejurkar
Copy link
Contributor Author

@jkotas Can you please give me direction to test file where should I write tests!
Thanks.

@jkotas
Copy link
Member

jkotas commented May 30, 2020

https://github.com/dotnet/runtime/blob/master/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs looks most appropriate.

@steveharter
Copy link
Member

Closing; no repro was found. See the original issue for more info.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-System.Reflection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShreyasJejurkar @jkotas @steveharter @Dotnet-GitSync-Bot