Use ConditionalFact/Theory for skipping RemoteExecutor on unsupported platforms #37479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @ViktorHofer |
akoeplinger
force-pushed
the
remoteexecutor-conditional
branch
3 times, most recently
from
6cabed3 to
674bb52
Compare
|
I thought we were exploring ways to do this without annotating all tests that use it. Did that turn out not to be possible? |
akoeplinger
force-pushed
the
remoteexecutor-conditional
branch
2 times, most recently
from
bec1b74 to
569d487
Compare
|
@stephentoub yes it turned out to be impossible |
|
Ok, thanks |
… platforms RemoteExecutor doesn't work on platforms that can't spawn processes like iOS/Android/WebAssembly.
akoeplinger
force-pushed
the
remoteexecutor-conditional
branch
from
569d487 to
668bc6a
Compare
safern
reviewed
Jun 8, 2020
ViktorHofer
approved these changes
Jun 8, 2020
…nditional # Conflicts: # src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
…nditional # Conflicts: # src/libraries/System.Diagnostics.Process/tests/ProcessStreamReadTests.cs
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteExecutor doesn't work on platforms that can't spawn processes like iOS/Android/WebAssembly.