Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to convert between hexadecimal strings and bytes #37546
Add methods to convert between hexadecimal strings and bytes #37546
Changes from 5 commits
2753cb6
3c96756
b546388
3f2b589
f54ef1e
044c710
300b725
df0392d
0dad775
25d222e
de2085b
7917e6d
8c89198
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really an
OutOfMemoryException
?(Source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ArgumentOutOfRangeException seems more appropriate. OOM should only be thrown by the CLR or interop code reinterpreting a native error.
(Framework Design Guidelines, 3rd edition)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the OOM for consistency with the Base64 methods here:
runtime/src/libraries/System.Private.CoreLib/src/System/Convert.cs
Lines 2547 to 2550 in 25d222e
I'll gladly change that to an AOOR though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to AOOR with a new exception message (no existing one seemed to fit).
Let me know if you like it better this way. See de2085b