Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable AIA retrieval in X509Chain #37680

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

bartonjs
Copy link
Member

Fixes #37485.

@bartonjs bartonjs added this to the 5.0 milestone Jun 10, 2020
@bartonjs bartonjs self-assigned this Jun 10, 2020
@ghost
Copy link

ghost commented Jun 10, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the double negatives hurt my head. Other than that, LGTM.

@bartonjs
Copy link
Member Author

System.Collections.Concurrent.Tests on mono/Windows_NT took too long to run, looks like #37186.

[Long Running Test] 'System.Collections.Concurrent.Tests.ConcurrentQueueTests.GetEnumerator_Generic_ExpectedElementsYielded', Elapsed: 00:14:22
[Long Running Test] 'System.Collections.Concurrent.Tests.ConcurrentStackTests.PushRange_Concurrent_ConsecutiveItemsInEachRange', Elapsed: 00:14:20
[Long Running Test] 'System.Collections.Concurrent.Tests.BlockingCollectionTests.TestBugFix544259', Elapsed: 00:14:22

@bartonjs bartonjs merged commit 2d369cf into dotnet:master Jun 12, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@bartonjs bartonjs deleted the chain_disable_aia branch April 9, 2021 21:11
@bartonjs bartonjs removed their assignment Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow X509Chain callers to prevent retrieval of missing certificates
3 participants