Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libraries] Properly skip thread failing WASM tests #38089

Merged
merged 6 commits into from
Jun 19, 2020
Merged

[libraries] Properly skip thread failing WASM tests #38089

merged 6 commits into from
Jun 19, 2020

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jun 18, 2020

Fixes #38044

@ghost
Copy link

ghost commented Jun 18, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@mdh1418 mdh1418 mentioned this pull request Jun 18, 2020
Closed
akoeplinger
akoeplinger reviewed Jun 18, 2020
View reviewed changes
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about [ConditionalFact] that should just be [Fact] but looks good otherwise.

src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs Show resolved Hide resolved
src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs Show resolved Hide resolved
src/libraries/System.Data.Odbc/tests/ReaderTests.cs Show resolved Hide resolved
src/libraries/System.Data.Odbc/tests/SmokeTest.cs Show resolved Hide resolved
@mdh1418 mdh1418 force-pushed the mdhwang/unskip_wasm_tests branch from b2361c6 to 2814fe4 Compare June 19, 2020 13:03
@mdh1418 mdh1418 force-pushed the mdhwang/unskip_wasm_tests branch from 2814fe4 to 5095ad6 Compare June 19, 2020 13:14
@jaredpar jaredpar mentioned this pull request Jun 19, 2020
Closed
@safern safern mentioned this pull request Jun 19, 2020
Closed
@akoeplinger akoeplinger merged commit 9ccfc40 into dotnet:master Jun 19, 2020
@mdh1418 mdh1418 deleted the mdhwang/unskip_wasm_tests branch June 22, 2020 17:58
This was referenced Jun 22, 2020
Merged
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@layomia layomia layomia left review comments

@akoeplinger akoeplinger akoeplinger left review comments

@jozkee jozkee Awaiting requested review from jozkee

@steveharter steveharter Awaiting requested review from steveharter

@steveisok steveisok Awaiting requested review from steveisok

Assignees
No one assigned
Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libraries] Skipping passing WASM tests
4 participants
@mdh1418 @akoeplinger @layomia @safern