-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MicrosoftPrivateIntellisensePackage and XmlDocFileRoot #38109
Conversation
Tagging subscribers to this area: @ViktorHofer |
Found a build error locally. Santi and I are investigating. |
It seems like the only shared location were we could define |
44ce241
to
303bc3b
Compare
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
For such shared properties we use Configurations.props. |
We can’t use Configurations.props. We tried it already. The reason for that is that when we’re building a pkgproj; arcade is imported after Configurations.props is imported and NugetPackageRoot is not defined at the moment this property is defined. We disable importing arcade from the root for anything under src/libraries. The only place I could think of was Versions.props where in both code paths (Build.proj restore and pkgproj build) arcade would already had defined NugetPackageRoot |
Makes sense. We should enable the root Arcade import. The reason I had to disable that was because we relied on the old configuration system. I believe there aren't any blockers anymore. |
Cool. Can we do that as part of another change? I believe there was an issue for that, right? I just don’t want to complicate this change. |
Sure |
XmlDocFileRoot
was defined in two places:packaging.props
anddocs.targets
.Moved it to a higher level to ensure it's only defined once, in
Directory.Build.props
. Made sure to define it afterNuGetPackageRoot
is defined.Also made sure the folder it reads is
net
instead ofnetcoreapp
, because the Docs build saves the .NET 5.0 intellisense files in thenet
folder, and the .NET 3.1 intellisense files in thenetcoreapp
folder.Updated the nupkg to consume to the latest available version in the feed
20200602.3
, which contains the Preview5 APIs.I will make a similar change in the Preview6 branch today.
Thanks @safern for your help in figuring out what changes needed to be made.