-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lots of NoWarns from .csproj files #38161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
stephentoub
force-pushed
the
removenowarn
branch
3 times, most recently
from
June 19, 2020 22:04
ea1a814
to
b012044
Compare
stephentoub
force-pushed
the
removenowarn
branch
from
June 20, 2020 09:38
b012044
to
fcd7c68
Compare
stephentoub
commented
Jun 20, 2020
...ices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx_Query.cs
Show resolved
Hide resolved
stephentoub
commented
Jun 20, 2020
src/libraries/System.Private.Xml/src/System/Xml/Core/XmlValidatingReaderImpl.cs
Show resolved
Hide resolved
stephentoub
commented
Jun 20, 2020
...urity.Cryptography.X509Certificates/src/System.Security.Cryptography.X509Certificates.csproj
Show resolved
Hide resolved
joperezr
reviewed
Jun 22, 2020
...m.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/SearchResults.cs
Show resolved
Hide resolved
joperezr
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Thanks, @joperezr |
danmoseley
reviewed
Jun 24, 2020
src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Show resolved
Hide resolved
danmoseley
reviewed
Jun 24, 2020
...Services.AccountManagement/src/System/DirectoryServices/AccountManagement/AdvancedFilters.cs
Show resolved
Hide resolved
danmoseley
reviewed
Jun 24, 2020
danmoseley
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.