Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder tracing tests: only track loads that tests are interested in #38251

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Jun 23, 2020

The binder tracing tests run multiple tests and use separate event listeners for each test. It is possible for a listener to be created after a load (that is not one we are testing) has started. This change makes the listener only track tracing of the loads that are being tested.

Resolves #38121

@elinor-fung elinor-fung added test-bug Problem in test source code (most likely) area-AssemblyLoader-coreclr labels Jun 23, 2020
@elinor-fung elinor-fung requested a review from vitek-karas June 23, 2020 00:50
@ghost
Copy link

ghost commented Jun 23, 2020

Tagging subscribers to this area: @vitek-karas
Notify danmosemsft if you want to be subscribed.

@elinor-fung elinor-fung merged commit 0e9f4ce into dotnet:master Jun 23, 2020
@elinor-fung elinor-fung deleted the binderTest-trackSpecific branch June 23, 2020 18:49
@josalem
Copy link
Contributor

josalem commented Jun 23, 2020

CC #38284

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-AssemblyLoader-coreclr test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinderTracingTest.ResolutionFlow.cmd failing with EventSourceException
3 participants