[wasm] Skip System.Configuration.ConfigurationManager test suite #38749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @safern, @ViktorHofer |
|
I think we should just skip the whole test assembly on browser in an AssemblyInfo.cs: [assembly: SkipOnMono("System.Configuration.ConfigurationManager is not supported on wasm", TestPlatforms.Browser)] |
MaximLipnin
force-pushed
the
wasm_enable_config_mangr_suite
branch
from
ad2ad8e to
db0db34
Compare
MaximLipnin
changed the title
akoeplinger
approved these changes
Jul 4, 2020
99 tasks
danmoseley
added
area-System.Configuration
and removed
area-Infrastructure-libraries
labels
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38422.
I marked some test classes/methods in System.Configuration.ConfigurationManager test suite as not running on Browser.Some of them are time consuming, a couple of them just fail.
Someone could take a look to decide whether they make sense on Wasm and if it's worth fixing/enabling them.
Most of the disabled tests contain an invocations of
ConfigurationManager.OpenExeConfiguration.The intermediate results of the local run:
Tests run: 510, Errors: 0, Failures: 0, Skipped: 1.Tests run: 536, Errors: 0, Failures: 0, Skipped: 1Since
System.Configuration.ConfigurationManageris a legacy netstandard library, delivered as independent nuget package, it makes sense to skip the whole test suite.