Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of CSE for GT_CNS_INT benefits ARM64 #39096

Merged
merged 8 commits into from
Jul 24, 2020
Merged

Implementation of CSE for GT_CNS_INT benefits ARM64 #39096

merged 8 commits into from
Jul 24, 2020

Commits on Jul 22, 2020

  1. Change the type of csdHashKey to size_t

    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    fb33602 View commit details
    Browse the repository at this point in the history

  2. Update gtCostSz and gtCostEx for constant nodes

    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    dff0476 View commit details
    Browse the repository at this point in the history

  3. Implementation of code size optimization, CSE of constant values for … 

    …ARM64

Implementation of code size optimization, CSE of constant values for ARM64
We will share a single CSE for constants that differ only in their low 12 bits on ARM64

Number of shared constant low bits set in target.h  CSE_CONST_SHARED_LOW_BITS
we use 12 bits on Arm platforms and 16 bits on XArch platforms

Disable the CSE of the REG_R2R_INDIRECT_PARAM on Arm32
as it hits  Assertion failed 'candidates != candidateBit' in lsra.cpp Line: 3723

Config variable: COMPlus_JitConstCSE
// Default 0: enable the CSE of Constants, including nearby offsets. (only for ARM64)
// If 1, disable all the CSE of Constants
// If 2, enable the CSE of Constants but don't combine with nearby offsets. (only for ARM64)
// If 3, enable the CSE of Constants including nearby offsets. (all platforms)
// If 4, enable the CSE of Constants but don't combine with nearby offsets. (all platforms)
//
    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7e8d826 View commit details
    Browse the repository at this point in the history

  4. Added additional Priority 0 test coverage for Floating Point optimiza… 

    …tions
    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    00592c6 View commit details
    Browse the repository at this point in the history

  5. Fix for COMPLUS_JitConstCSE=4

    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    80fb3b2 View commit details
    Browse the repository at this point in the history

  6. Renamed config variable from COMPlus_JitDisableConstCSE to COMPlus_Ji… 

    …tConstCSE
    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    2ee8e08 View commit details
    Browse the repository at this point in the history

  7. Updated with Codereview feedback, removed sort from Const CSE phase

    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    47f2365 View commit details
    Browse the repository at this point in the history

  8. Fix for assertionProp issue in the refTypesdynamic test

    @briansull
    briansull committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    fb2f8d5 View commit details
    Browse the repository at this point in the history