-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][wasm] Configuring request options in Browser WebAssembly #39182
Conversation
…owser WebAssembly
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/ncl |
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestMessage.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestMessage.cs
Outdated
Show resolved
Hide resolved
I started going through the PR, but it doesn't appear to match the approved API. I'll hold off reviewing further until that's resolved. Thanks. |
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestOptions.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/HttpRequestOptionsKey.cs
Outdated
Show resolved
Hide resolved
…request-options
…request-options
…RequestOptionsKey<object>'
...xtensions.Http/tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs
Outdated
Show resolved
Hide resolved
@marek-safar @stephentoub is this ready? |
@scalablecory and/or @geoffkizer, can you review while I'm out? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me now, can we get a review from libraries/networking
Could someone from libraries/networking give this a look over? @scalablecory and/or @geoffkizer |
@geoffkizer can you please help with code review here on behalf of ncl? Thanks! |
I haven't been part of the design discussions so I'm just assuming we're all happy with the design as approved -- with that said, code looks good to me. |
Thanks @geoffkizer |
…otnet#39182) * [browser][wasm] Initial addition of configuring request options in Browser WebAssembly * Fix key code. Not what was proposed * Add TryGetValue<TValue> and Set<TValue> as per proposal * Add missing obsolete attribute * Address review comments * Update tests to use Options and not obsolete Properties. * Implement IDictionary<string, object?> explicitly * Update tests to use Options and not obsolete Properties. * Add HttpRequestOptions source to the System.Net.Http.Unit.Tests project to fix build. * Address review comments - explicit * Fix build error cannot convert from 'string' to 'System.Net.Http.HttpRequestOptionsKey<object>' * Add tests for HttpRequestOptions * Fix test build * Add special case code for NETFRAMEWORK for API change. * #endif out of place fix * #endif out of place fix
This dotnet/runtime PR marked Properties as obsolete: dotnet/runtime#39182 Since we use warnings as errors, we have to change our code.
This dotnet/runtime PR marked Properties as obsolete: dotnet/runtime#39182 Since we use warnings as errors, we have to change our code.
Initial implementation of request options used by Browser WebAssembly.
See proposal: #34168