WASM: Fix System.Diagnostics.TextWriterTraceListener tests #39186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using Process.GetCurrentProcess() which throws PNSE on WebAssembly.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
99 tasks
stephentoub
reviewed
Jul 13, 2020
| using Process process = Process.GetCurrentProcess(); | ||
| s_processName = processName = process.ProcessName; | ||
| } | ||
| catch (PlatformNotSupportedException) |
There was a problem hiding this comment.
Suggested change
| catch (PlatformNotSupportedException) | |
| catch (PlatformNotSupportedException) // Process isn't supported on Browser |
There was a problem hiding this comment.
Did you consider instead doing a platform check?
if (RuntimeInformation.IsOSPlatform(OSPlatform.Browser) { ... }
else { ... }There was a problem hiding this comment.
yeah but I think over the last couple PRs we landed on the consensus to prefer catching PNSE instead for cases like this.
There was a problem hiding this comment.
over the last couple PRs
Oh there have been more of these? I must have missed that. Could you point me to some examples?
There was a problem hiding this comment.
E.g. b62b16a#diff-ce3739bb88265fab85205217d762f650R70-R79 and the discussion on the PR: #38968 (comment)
safern
approved these changes
Jul 14, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was using Process.GetCurrentProcess() which throws PNSE on WebAssembly.