In mono_wasm_invoke_js_marshalled, pass through treatResultAsVoid param #39435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Not sure what area labels are most applicable. @lewing, could you help route this to the right person? Or maybe the right person is you :) |
kg
approved these changes
Jul 16, 2020
|
It doesn't (code here). The current implementation will ignore the extra param right now, and we'll update it to handle it usefully once this runtime change flows through. |
lewing
approved these changes
Jul 17, 2020
|
The windows failure is unrelated to the browser javascript changes. |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking JS functions, sometimes they return values that aren't JSON serializable. This would then result in a JSON serialization exception.
But this doesn't make sense in the case where the developer made the call using
InvokeVoidorInvokeVoidAsync. In these cases, we know they don't want the response, so why would we even try serializing and sending it?This PR adds a new parameter that Blazor can use to control whether the result value is to be JSON-serialized or just discarded. The real implementation of the rest of the functionality will happen in the aspnetcore repo.