Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSBuild Traversal SDK that contains StopOnFirstFailure support #39481

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

safern
Copy link
Member

@safern safern commented Jul 16, 2020

This adds support for: microsoft/MSBuildSdks#186

This fixes the issue in our traversal builds where if I run build.cmd libs.native+libs.ref and libs.native fails, we keep going and build refs as well, causing cryptic un-diagnosable issues.

I remember we had an issue opened for this but I can't find it.

@ghost
Copy link

ghost commented Jul 17, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member Author

safern commented Jul 17, 2020

Browser test failures are: #39487

@safern
Copy link
Member Author

safern commented Jul 17, 2020

Merging as it hit the OSX disconnection issue. And FreeBSD just didn't update in the GH UI.

@safern safern merged commit a5ca174 into dotnet:master Jul 17, 2020
@safern safern deleted the updateTraversalSdk branch July 17, 2020 02:02
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants