WASM: Enable System.Reflection.MetadataLoadContext tests #39651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Tests run: 559, Errors: 0, Failures: 0, Skipped: 0. Time: 5.4221639s`
safern
reviewed
Jul 20, 2020
99 tasks
safern
reviewed
Jul 20, 2020
eng/testing/tests.mobile.targets
Outdated
| @@ -132,6 +132,9 @@ | |||
| <WasmFilesToIncludeInFileSystem Include="@(ContentWithTargetPath)" /> | |||
| <WasmFilesToIncludeInFileSystem Include="@(ReferenceCopyLocalPaths)" Condition="'%(ReferenceCopyLocalPaths.BuildReference)' == 'true' and !$([System.String]::new('%(ReferenceCopyLocalPaths.Identity)').EndsWith('.resources.dll'))" /> | |||
| <WasmFilesToIncludeInFileSystem Include="@(WasmSatelliteAssemblies)" TargetPath="%(WasmSatelliteAssemblies.CultureName)\%(WasmSatelliteAssemblies.Filename)%(WasmSatelliteAssemblies.Extension)" /> | |||
| <WasmFilesToIncludeInFileSystem Include="$(PublishDir)System.Private.CoreLib.dll" Condition="'$(AssemblyName)' == 'System.Reflection.MetadataLoadContext.Tests'" /> | |||
There was a problem hiding this comment.
Can we move this to an independent itemgroup so that we share the condition instead of repeating it?
safern
approved these changes
Jul 21, 2020
|
WASM test failure is due to: #39473 |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
`Tests run: 559, Errors: 0, Failures: 0, Skipped: 0. Time: 5.4221639s`
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests run: 559, Errors: 0, Failures: 0, Skipped: 0. Time: 5.4221639s