Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-preview8] Add JsonNumberHandling & support for (de)serializing numbers from/to string #39685

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Jul 21, 2020

Port of #39363 into the release/5.0-preview8 branch.

Description

Fixes #30255 in preview 8.

This adds the APIs and implementation for a JsonSerializer feature that enables reading and writing numbers from/to JSON strings, including the floating-point constant representations "NaN", "Infinity", and "-Infinity".

Customer Impact

This is a highly requested feature and will enable better interop between the users of the serializer and various API endpoints across the web.

@layomia layomia added Servicing-consider Issue for next servicing release review area-System.Text.Json labels Jul 21, 2020
@layomia layomia added this to the 5.0.0 Preview 8 milestone Jul 21, 2020
@layomia layomia self-assigned this Jul 21, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@steveharter steveharter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; direct port of master

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 21, 2020
@danmoseley
Copy link
Member

approved by Steve offline

@ghost
Copy link

ghost commented Jul 21, 2020

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@layomia
Copy link
Contributor Author

layomia commented Jul 21, 2020

Build iOS arm64 Debug AllSubsets_Mono run was canceled.

@layomia layomia merged commit 44446b1 into dotnet:release/5.0-preview8 Jul 21, 2020
@layomia layomia deleted the json_number_pre8 branch July 21, 2020 17:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants