[runtime] Fix some more gc tracking problems in create_cattr_named/typed_arg. #39856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
alexischr,
CoffeeFlux,
lambdageek and
thaystg
as code owners
|
Tagging subscribers to this area: @CoffeeFlux |
CoffeeFlux
approved these changes
Jul 23, 2020
src/mono/mono/metadata/handle.h
Outdated
| @@ -367,6 +367,9 @@ typedef struct _MonoTypeofCastHelper *MonoTypeofCastHelper; // a pointer type un | |||
|
|
|||
| #define MONO_HANDLE_CAST(type, value) (MONO_HANDLE_CAST_FOR (type) ((value).__raw)) | |||
|
|
|||
| /* Simpler version if the handle is not used */ | |||
| #define MONO_HANDLE_PIN(object) MONO_HANDLE_NEW (MonoObject, (object)) | |||
There was a problem hiding this comment.
If this only works for MonoObjects, the macro name should probably have that at the end. I'm assuming that's the case since you didn't use it above for the MonoArray?
There was a problem hiding this comment.
It should work for all objects, we might need to put casts into it in the future to make that happen.
There was a problem hiding this comment.
Think I'd rather just put the casts in and use for the MonoArray in this PR then, but it's not a huge deal.
vargaz
added a commit
to vargaz/runtime
that referenced
this pull request
Jul 24, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.