Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace #40004

Merged
merged 2 commits into from
Jul 29, 2020
Merged

[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namespace #40004

merged 2 commits into from
Jul 29, 2020

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Jul 28, 2020 •
edited by safern
Loading

There is no repro for #38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see #39346).

Fixes: #38807

The test run result: Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.

@ghost
Copy link

ghost commented Jul 28, 2020

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@jaredpar jaredpar mentioned this pull request Jul 28, 2020
Closed
@safern
Copy link
Member

safern commented Jul 28, 2020 •
edited
Loading

I see you're re-enabling one test hitting: #38807... What about this one?

runtime/src/libraries/System.Net.WebSockets.WebSocketProtocol/tests/WebSocketProtocolTests.cs

Line 9 in 6072e4d

[ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)]

@MaximLipnin
Copy link
Contributor Author

Filed #40042 to track memory access out of bounds issue.

@akoeplinger akoeplinger merged commit 6ab00b4 into dotnet:master Jul 29, 2020
@MaximLipnin MaximLipnin deleted the wasm_system.net.webclient_test branch July 29, 2020 09:16
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@MaximLipnin @Jacksondr5
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
6f99b23 
…ace (dotnet#40004)

There is no repro for dotnet#38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see dotnet#39346).

Fixes: dotnet#38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@steveisok steveisok Awaiting requested review from steveisok

@mdh1418 mdh1418 Awaiting requested review from mdh1418

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] Enable System.Net.WebSockets.Tests.WebSocketTests class
6 participants
@MaximLipnin @safern @akoeplinger @karelz @danmoseley @Dotnet-GitSync-Bot