Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead resource strings from Microsoft.VisualBasic.Core #40053

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Remove dead resource strings from Microsoft.VisualBasic.Core #40053

merged 1 commit into from
Jul 30, 2020

Conversation

Marusyk
Copy link
Member

@Marusyk Marusyk commented Jul 28, 2020

Fixes #40016

Please review
Thank you in advance

@ghost
Copy link

ghost commented Jul 28, 2020

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jul 29, 2020 

  Starting:    Microsoft.VisualBasic.Core.Tests (parallel test collections = on, max threads = 2)
    Microsoft.VisualBasic.Tests.ConversionTests.ErrorToString_WithErrorNumber(errorNumber: 7) [FAIL]
      Assert.NotNull() Failure
      Stack Trace:
        /_/src/libraries/Microsoft.VisualBasic.Core/tests/ConversionTests.cs(145,0): at Microsoft.VisualBasic.Tests.ConversionTests.ErrorToString_WithErrorNumber(Int32 errorNumber)
    Microsoft.VisualBasic.Tests.ErrObjectTests.FilterDefaultMessage [FAIL]
      Assert.NotEqual() Failure
      Expected: Not "Exception from HRESULT: 0x80"
      Actual:   "Exception from HRESULT: 0x80"
      Stack Trace:
        /_/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs(91,0): at Microsoft.VisualBasic.Tests.ErrObjectTests.FilterDefaultMessage()

@jkotas jkotas mentioned this pull request Jul 30, 2020
Closed
@jkotas
Copy link
Member

jkotas commented Jul 30, 2020

Opened #40115 on the test failure

jkotas
jkotas approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 44add55 into dotnet:master Jul 30, 2020
@danmoseley
Copy link
Member

Nice cleanup, thank you @Marusyk . If you are interested in another contribution .. https://github.com/dotnet/runtime/issues?q=is%3Aopen+is%3Aissue+label%3Aup-for-grabs

@Marusyk Marusyk deleted the rmarusyk/40016 branch July 30, 2020 07:53
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@Marusyk @Jacksondr5
Remove dead resource strings from Microsoft.VisualBasic.Core (dotnet#…
fb44633 
…40053)
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cston cston cston left review comments

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-Microsoft.VisualBasic
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Some dead resource strings in Microsoft.VisualBasic.Core
6 participants
@Marusyk @jkotas @danmoseley @cston @karelz @Dotnet-GitSync-Bot