Remove unused local in System.Configuration.ConfigurationManager #40583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @maryamariyan |
|
This is probably fine, but the indexer would cause a call to @maryamariyan can review - another option is to just do |
maryamariyan
approved these changes
Aug 10, 2020
safern
added a commit
to safern/runtime
that referenced
this pull request
Aug 31, 2020
…ger (dotnet#40583)" This reverts commit a4eba0a.
jkotas
pushed a commit
that referenced
this pull request
Sep 1, 2020
safern
added a commit
that referenced
this pull request
Sep 1, 2020
* Revert "Remove unused local in System.Configuration.ConfigurationManager (#40583)" This reverts commit a4eba0a. * Rename unused variable and add regression test * PR feedback Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
maryamariyan
added
extensions-port
area-System.Configuration
and removed
area-Extensions-Configuration
extensions-port
labels
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused local 'temp' in System.Configuration.ConfigurationManager
Fixes part of #30457