Disable test hanging in some configurations #40628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
hoyosjs
approved these changes
Aug 10, 2020
|
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
I looked at the dump and it's indeed in the CRT just chugging away. |
|
I'm going to change it to a 10x timeout instead, but I'll let this merge first since it's causing pain. |
|
Builds and tests succeeded on Windows, that's sufficient validation for this change, I will go ahead and merge since it seems to be breaking so many people. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test recently added to protect the fix for bounds checking Append to a huge StringBuilder is sometimes hanging on some configurations while doing the huge Append.
My assumption is that the machine is just overloaded copying 4GB, and the product fix is OK. Disabling this test for now.
Relates to #40625