Fix concurrent collections CA1836 rule violations

[jozkee]

Follow-up to dotnet/roslyn-analyzers#3978

Fix places where the rule detects an inefficient usage of Count == 0 or similar condition after changing the rule to only diagnose allowed types (concurrent types for now).

Also updates rule severity to Warning in CodeAnalysis.ruleset file.

cc @mavasani @jeffhandley

[ghost]

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

[stephentoub]

Nice

[jozkee]

Seems like CI issues are due to dotnet/runtime hasn't ingested the latest bits from dotnet/roslyn-analyzers, maybe we should holf-off changing severity until then.

[mavasani]

Seems like CI issues are due to dotnet/runtime hasn't ingested the latest bits from dotnet/roslyn-analyzers, maybe we should holf-off changing severity until then.

I think you can just bump up the below to 3.3.0-beta3.20410.1 to pick up the latest version from https://dev.azure.com/dnceng/public/_packaging?_a=package&feed=dotnet5&package=Microsoft.CodeAnalysis.NetAnalyzers&protocolType=NuGet&version=3.3.0-beta3.20410.1&view=versions in this PR itself:

runtime/eng/Analyzers.props

Line 9 in aa5fdab

<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="3.3.0-beta3.20407.4" PrivateAssets="all" />

[ghost]

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[jkotas]

"The operation is not allowed on non-connected sockets.". #38159 ?