Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disabled test to large timeout instead #40633

Closed
wants to merge 2 commits into from
Closed

Change disabled test to large timeout instead #40633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c64f6
Disable SB test
danmoseley Aug 10, 2020
69494e1
Add timeout instead
danmoseley Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libraries/System.Runtime/tests/System/Text/StringBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,6 +2234,7 @@ public static void EqualsIgnoresMaxCapacity()
[ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
public static unsafe void FailureOnLargeString()
{
RemoteInvokeOptions options = new RemoteInvokeOptions { TimeOut = 600 * 1000 }; // Takes a long time on debug builds
RemoteExecutor.Invoke(() => // Uses lots of memory
{
AssertExtensions.ThrowsAny<ArgumentOutOfRangeException, OutOfMemoryException>(() =>
Expand All @@ -2246,7 +2247,7 @@ public static unsafe void FailureOnLargeString()
});

return RemoteExecutor.SuccessExitCode; // workaround https://github.com/dotnet/arcade/issues/5865
}).Dispose();
}, options).Dispose();
}
}
}