-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict generational aware analysis to processes that matches the command line configuration #41052
Merged
cshung
merged 2 commits into
dotnet:master
from
cshung:public/dev/andrewau/command-line-filter
Aug 26, 2020
Merged
Restrict generational aware analysis to processes that matches the command line configuration #41052
cshung
merged 2 commits into
dotnet:master
from
cshung:public/dev/andrewau/command-line-filter
Aug 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/gc |
ivdiazsa
reviewed
Aug 19, 2020
Maoni0
reviewed
Aug 20, 2020
Maoni0
reviewed
Aug 20, 2020
Maoni0
reviewed
Aug 20, 2020
cshung
force-pushed
the
public/dev/andrewau/command-line-filter
branch
2 times, most recently
from
August 21, 2020 17:14
640a34c
to
6341cd4
Compare
cshung
changed the title
Restrict generational aware analysis to processes that matches the command line configuration
[WIP] Restrict generational aware analysis to processes that matches the command line configuration
Aug 21, 2020
cshung
force-pushed
the
public/dev/andrewau/command-line-filter
branch
from
August 21, 2020 23:52
6341cd4
to
d766e5c
Compare
cshung
changed the title
[WIP] Restrict generational aware analysis to processes that matches the command line configuration
Restrict generational aware analysis to processes that matches the command line configuration
Aug 21, 2020
Maoni0
approved these changes
Aug 26, 2020
cshung
added a commit
to cshung/runtime
that referenced
this pull request
Aug 26, 2020
…mmand line configuration (dotnet#41052)
cshung
added a commit
that referenced
this pull request
Aug 26, 2020
…mmand line configuration (#41052)
ghost
locked as resolved and limited conversation to collaborators
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps with the scenario where customers who wanted to perform the analysis but otherwise have little control over the spawning of the process that requires the analysis.
This also adds
gc_index
to the payload of the delimiter events to make it easier to correlate with traces obtained at the same time (e.g throughPerfView /GCCollectOnly
.)