Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Address warnings for possibly null array elements #41102

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 20, 2020

Backport of #41046 to release/5.0

/cc @safern @cston

Customer Impact

The fix relaxes the nullability annotations on several methods in System.Runtime.CompilerServices.Unsafe, to avoid unnecessary warnings from the updated C# compiler.

Testing

Risk

Low risk. The change avoids warnings when compiling System.Private.Corelib but does not affect semantics.

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@safern
Copy link
Member

safern commented Aug 20, 2020

@danmosemsft we need this to unblock arcade update in 5.0

@danmoseley
Copy link
Member

@safern - OK - at this point I think you can assume anything necessary to make the infrastructure function correctly you can just merge (basically if I have no option. . you don't need to ask 😄 )

@safern safern merged commit 5114bf3 into release/5.0 Aug 20, 2020
@safern safern deleted the backport/pr-41046-to-release/5.0 branch August 20, 2020 20:01
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants