Fix Char.GetUnicodeCategory to returns correct results #41200
Conversation
|
CC @danmosemsft @ericstj as this is a candidate for 5.0. Of course I'll fill the template when I open the porting PR in the release branch. This is just FYI for now. |
|
@safern @GrabYourPitchforks The changes in the test include unrelated fix in time zones. I encountered this failure after getting the new Windows updates which I expect most of the people will run into soon. Also, if we port this fix to 5.0 release branch, it will be good to include this test fix too to avoid the failure there too. |
|
CC @jkotas @stephentoub as they were recommending doing this fix. |
src/libraries/System.Private.CoreLib/src/System/Globalization/CharUnicodeInfo.cs
Outdated
Show resolved
Hide resolved
|
Thanks @jkotas I have addressed all feedback points you sent. |
|
The CI failure is unrelated and tracked by #41078 |
| }; | ||
| foreach (char c in GetTestChars(categories)) | ||
| Assert.True(char.IsLetter(c.ToString(), 0)); | ||
| Assert.True(char.IsLetter(c.ToString(), 0), $"'{c}':{(int)c:x4} Is Not Letter"); |
There was a problem hiding this comment.
Thanks for clarifying the error message! :)
|
/backport to release/5.0 |
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/222421865 |
ghost
locked as resolved and limited conversation to collaborators
Fixes #10990
Details listed in the breaking changes doc.