Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve Windows error handling in Diagnostics IPC" #41220

Merged
merged 1 commit into from
Aug 23, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 22, 2020

Reverts #41008

Fixes #41217

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

josalem
josalem approved these changes Aug 22, 2020
@jkotas jkotas merged commit 15839c0 into master Aug 23, 2020
josalem pushed a commit to josalem/runtime that referenced this pull request Aug 23, 2020
@jkotas jkotas deleted the revert-41008-dev/josalem/windows-ipc-errorhandling branch August 24, 2020 15:06
ghost pushed a commit that referenced this pull request Aug 25, 2020
* Revert "Revert "Improve Windows error handling in Diagnostics IPC (#41008)" (#41220)"

This reverts commit 15839c0.

* don't use win8+ API
josalem pushed a commit to josalem/runtime that referenced this pull request Aug 25, 2020
* Revert "Revert "Improve Windows error handling in Diagnostics IPC (dotnet#41008)" (dotnet#41220)"

This reverts commit 15839c0.

* don't use win8+ API
josalem pushed a commit that referenced this pull request Aug 25, 2020
…n Windows (#41338)

* Revert "Revert "Improve Windows error handling in Diagnostics IPC (#41008)" (#41220)"

This reverts commit 15839c0.

* don't use win8+ API
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All libraries tests failing on Win7 x86
4 participants