[release/5.0] Update SYSLIB0012 obsoletion messages to be clear and consistent #41483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
@ericstj Please consider this for |
|
It looks a bit odd to make this obsolete message talk about .NET Framework explicitly when the other obsolete messages do not. I have commented on it in #39261 (comment) I do not care enough about this detail. |
jkotas
approved these changes
Aug 27, 2020
|
Thanks @jkotas. Sorry I missed that comment previously, but my care level for that detail is also low. @terrajobst agreed that the spec's message didn't provide enough context though. |
ericstj
approved these changes
Aug 27, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41467 to release/5.0
/cc @jeffhandley
Customer Impact
The obsoletion message that was documented for
SYSLIB0012was unclear without surrounding context; it didn't state which APIs were obsolete nor did it state which Type theLocationproperty was on.Additionally, we found that the message used in
srcwas different from what was on therefassembly; therefassembly had a clearer message. This makes the messages consistent across them while also adding the context for improved clarity.Testing
Verified by introducing a violation (unsuppressing one of our internal suppressions) and reviewing the error message seen.
Risk
Very low. This is changing string literals used in
Obsoleteattributes.