-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SafeSocketHandle: avoid potential blocking of finalizer thread #41508
Merged
Commits on Aug 28, 2020
-
SafeSocketHandle: avoid potential blocking of finalizer thread
When the Socket is Disposed, it attempts to make all on-going operations abort. It does this in a loop, and decides there are no on-going operations when the reference count becomes zero and the handle gets released. SafePipeHandle holds a reference to SafeSocketHandle. This prevents the reference count to drop to zero, and causes the dispose to loop infinitly. When the Socket is disposed from the finalizer thread, it is no longer used for operations and we can skip the loop. This avoids blocking the finalizer thread when the reference count can't drop to zero.
Configuration menu - View commit details
-
Copy full SHA for 6d85a49 - Browse repository at this point
Copy the full SHA 6d85a49View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccc41c9 - Browse repository at this point
Copy the full SHA ccc41c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c41150 - Browse repository at this point
Copy the full SHA 8c41150View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43874bb - Browse repository at this point
Copy the full SHA 43874bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99de1e5 - Browse repository at this point
Copy the full SHA 99de1e5View commit details
Commits on Aug 31, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 16e62fa - Browse repository at this point
Copy the full SHA 16e62faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b88432f - Browse repository at this point
Copy the full SHA b88432fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c52ab27 - Browse repository at this point
Copy the full SHA c52ab27View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec7b055 - Browse repository at this point
Copy the full SHA ec7b055View commit details -
Configuration menu - View commit details
-
Copy full SHA for a44fe82 - Browse repository at this point
Copy the full SHA a44fe82View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.