-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading cpu cache size for Alpine(musl) #41532
Conversation
Tagging subscribers to this area: @dotnet/gc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@mangod9 Could you please also apply @am11 's suggestion: #41398 (comment) |
wondering if we might need to special case arm32 too, since I am seeing arm build failures, its not quite apparent from the errors whether new code is causing it, but seems suspicious. |
The ARM build errors are:
|
Ah yes, I see them now in the raw build log. CI seems to suggest the native build was successful (the leg is green too), will follow up with Infra on this. Here are the final few lines from the build log
|
The build infra issue is #34496 |
/backport to release/5.0 |
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/229731217 |
Is there any way we could ensure that this problem never comes back? Like having a unit test that asserts that |
@adamsitnik created #41708 for ensuring this doesnt regress. |
Should resolve #41398. Will need to backport to .net 5.