[release/5.0-rc2] Fix multiple version strings in coreclr shared libraries #41735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
We were incorrectly adding the version.c source to all coreclr libraries and not just the shared ones. That caused multiple occurences of the version string in coreclr shared libraries composed of sublibraries. This change fixes it by adding that source file for shared libraries only. I've also discovered that libcoreclrtraceptprovider.so was missing the version string completely, so I've added it there.
jkotas
approved these changes
Sep 2, 2020
jeffschwMSFT
approved these changes
Sep 3, 2020
jamshedd
added
Servicing-approved
|
Approved for RC2. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41711 to release/5.0-rc2
/cc @janvorli
Customer Impact
Attempt to get version string for any coreclr shared library would get that string repeated many times (21 times for coreclr). This may break tooling that check the version.
Testing
Local testing, checking that all shared libraries we build now contain exactly one version string.
Risk
Low, it has no impact on code execution.