Fix exception mapping during expect 100 cancellation. #41800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failing test is #37838 |
scalablecory
approved these changes
Sep 8, 2020
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnection.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/5.0-rc2 |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/246289373 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered during HTTP stress tests for HTTP 1.1
The exception from
sendRequestContentTaskwas thrown as-is instead of being mapped as any other exception (e.g. being wrapped inOperationCanceledExceptionwhen task was cancelled)Stress failure: https://dev.azure.com/dnceng/public/_build/results?buildId=796633&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=8030b67c-413b-5f79-b1fb-b1ba3f08bc47&l=1235
The related code block has been introduced in 5.0 (#38774) and this is a regression from 3.1: a different type of exception is thrown for cancellation than
TaskCancelledException.Contributes to #40388