-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 publishing #41899
V3 publishing #41899
Conversation
Tagging subscribers to this area: @ViktorHofer |
@ViktorHofer yes that is correct. |
For stable build test ->https://dnceng.visualstudio.com/internal/_build/results?buildId=803153&view=results @mmitche please merge this PR for me, I do not have access to merge this one. |
@epananth my question was if we can/should move the whole "Validate Build Assets" stage out of the build. |
@epananth I think we can for v3 publishing. If none of the SDL, etc. validations are enabled and v3 is enabled, then I don't think this stage doesn't have any real purpose. It used to verify that the default channel was available, but in v3 this is not a relevant concern. Does that sound right to you? |
Thanks @mmitche! I created a issue to safely remove this stage for V3. |
@epananth is there a plan to move master to publishing v3 as well? |
@jkoritzinsky you can just merge release/5.0-rc2 to master then it should pick up the V3 changes. |
We don't merge release branches back to master in dotnet/runtime. We exclusively use the dual-checkin model. If this change should work as written against master, we can use the backport GitHub action to port it to master. |
oh okay, good to know. The changes should work in master. Like discussed, I will run my changes against master and back port it to master. |
Use V3 publishing for runtime
Test with default channel => https://dev.azure.com/dnceng/internal/_build/results?buildId=802296&view=results
Test without default channel => https://dev.azure.com/dnceng/internal/_build/results?buildId=802367&view=results