Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 publishing #41899

Merged
merged 1 commit into from
Sep 9, 2020
Merged

V3 publishing #41899

merged 1 commit into from
Sep 9, 2020

Conversation

epananth
Copy link
Member

@epananth epananth commented Sep 4, 2020

@ghost
Copy link

ghost commented Sep 8, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member

@epananth @mmitche can/should the post build checks also be moved into the outer ring validation?

image

@epananth
Copy link
Member Author

epananth commented Sep 9, 2020

@ViktorHofer yes that is correct.

@epananth
Copy link
Member Author

epananth commented Sep 9, 2020

For stable build test ->https://dnceng.visualstudio.com/internal/_build/results?buildId=803153&view=results

@mmitche please merge this PR for me, I do not have access to merge this one.

@mmitche mmitche merged commit 81993fa into dotnet:release/5.0-rc2 Sep 9, 2020
@ViktorHofer
Copy link
Member

@epananth my question was if we can/should move the whole "Validate Build Assets" stage out of the build.

@mmitche
Copy link
Member

mmitche commented Sep 9, 2020

@epananth my question was if we can/should move the whole "Validate Build Assets" stage out of the build.

@epananth I think we can for v3 publishing. If none of the SDL, etc. validations are enabled and v3 is enabled, then I don't think this stage doesn't have any real purpose. It used to verify that the default channel was available, but in v3 this is not a relevant concern.

Does that sound right to you?

@epananth
Copy link
Member Author

epananth commented Sep 9, 2020

Thanks @mmitche! I created a issue to safely remove this stage for V3.

@jkoritzinsky
Copy link
Member

@epananth is there a plan to move master to publishing v3 as well?

@epananth
Copy link
Member Author

@jkoritzinsky you can just merge release/5.0-rc2 to master then it should pick up the V3 changes.

@jkoritzinsky
Copy link
Member

We don't merge release branches back to master in dotnet/runtime. We exclusively use the dual-checkin model.

If this change should work as written against master, we can use the backport GitHub action to port it to master.

@epananth
Copy link
Member Author

oh okay, good to know.

The changes should work in master. Like discussed, I will run my changes against master and back port it to master.

epananth added a commit to epananth/runtime that referenced this pull request Sep 11, 2020
mmitche pushed a commit that referenced this pull request Sep 17, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants