Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify condition to match message: #41933

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Modify condition to match message: #41933

merged 1 commit into from
Sep 7, 2020

Conversation

kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Sep 7, 2020

  • Since we are throwing: net_http_value_must_be_greater_than, 0 it makes more sense to use the same value in the condition.

Close: #41932

- Since we are throwing: `net_http_value_must_be_greater_than, 0` it makes more sense to use the same value in the condition.
@kjpou1 kjpou1 self-assigned this Sep 7, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit 228acfd into dotnet:master Sep 7, 2020
@kjpou1 kjpou1 deleted the wasm-sockethandler-nit branch September 8, 2020 07:38
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify condition used in SocketsHttpHandler
4 participants