-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete dead System.Net.Connections code #42099
Conversation
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ericstj can you see anything else that might need updating -- eg., where it would be packaged in (but we believe it currently isn't)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We didn't package this before. It was only shipping inside the shared framework and #41648 removed that. |
@geoffkizer / @karelz did we get tactics permission for this? If not it's probably not worth raising now. Arguably it's part of the original change. |
Not that I'm aware of. |
I am sorry - I have note realized that this PR was against the release branch. It did not have the release tag in the title. |
It's fine @jkotas no harm done 😃 |
This code is no longer used. Delete it from the 5.0 release to prevent confusion or accidents.