[release/5.0-rc2] Fixing TargetHasAVXSupportCheck to read ECX not EDX #42102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@jeffhandley one for a tactics mail I think |
jeffschwMSFT
added
the
area-CodeGen-coreclr
jeffschwMSFT
approved these changes
Sep 11, 2020
|
Ah yes it makes more sense for Jeff S to take this rather than Jeff H given the change. |
|
Thank you, @jeffschwMSFT. |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42089 to release/5.0-rc2
/cc @tannergooding
Customer Impact
Customers may see incorrect results when using
Vector<T>or may get a segmentation fault.Testing
It was validated that this resolves the corresponding issue reported by RedHat: #41584
Risk
Low. This updates a check to use a named constant to avoid the off-by one error. The bug was introduced in https://github.com/dotnet/runtime/pull/40167/files#r486571424 but was missed as part of a related fix done in #40615 prior to the RC1 lockdown.