Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of repo analyzers and warnings-as-errors #42272

Merged
merged 5 commits into from
Sep 17, 2020

Conversation

stephentoub
Copy link
Member

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my one question this looks great. Thanks a lot

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I love getting to zero warnings!

I would suggest triggering the
runtime-coreclr outerloop job to see what the coreclr Pri-1 test build looks like.

Looks like the coreclr test wrappers are failing to build now

davmason and others added 5 commits September 16, 2020 18:00
When we brought in the new SDK, it enabled analyzers by default (which then used our custom ruleset), but a bunch of projects (in particular tests) weren't expecting that, such that we now have thousands of warnings in the repo. This opts-out those projects.

It also enables warnings-as-errors at the root level of the repo, to hopefully avoid such warning storms in the future, and to also clean up the remaining that exist.  This includes a bunch of new obsoletion and platform compat warnings that are firing in the runtime tests.

We may choose to run analyzers on additional projects in the future where it's currently disabled, but this gets us back to a state at least as good if not better than we were previously.
Fixes the warnings that were triggered by our rule set applying to this project.  All fixes were automated.
@stephentoub
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@stephentoub
Copy link
Member Author

@BruceForstall, how do I trigger your recommended leg?

@jkotas
Copy link
Member

jkotas commented Sep 17, 2020

It is to be done manually from AzDO UI:

  1. Navigate to
    image in AzDO
  2. Click on "Run pipeline" blue button and use refs/pull/42272/head as the branch name

@stephentoub
Copy link
Member Author

Thanks, @jkotas. And it looks like you kicked it off; cool.

@stephentoub
Copy link
Member Author

Failures are outerloop coreclr test failures rather than build failures due to warnings-as-errors. Official build also passed.

@stephentoub stephentoub merged commit e0e1919 into dotnet:master Sep 17, 2020
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Almost 45000 warnings in coreclr Pri-1 test build