Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullable annotation on Socket.BeginSendFile #42623

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Fix nullable annotation on Socket.BeginSendFile #42623

merged 1 commit into from
Sep 23, 2020

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Sep 23, 2020 •
edited
Loading

Leftover from #42535 review feedback

@ghost
Copy link

ghost commented Sep 23, 2020

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

@ghost
Copy link

ghost commented Sep 23, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

eerhardt
eerhardt approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this.

@stephentoub stephentoub merged commit beddcb1 into dotnet:master Sep 23, 2020
@stephentoub stephentoub deleted the beginsendfile branch September 23, 2020 18:34
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-System.Net.Sockets
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stephentoub @eerhardt @karelz @Dotnet-GitSync-Bot