Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle libunwind_xdac partial C11 support #42997

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Oct 2, 2020

For newer Insider Windows SDKs, the stdalign.h header is present, but the alignas macro is not
defined unless the compiler command line adds the std:c11 or newer option.

Until we can set the std:c11 flag, work around the missing alignas macro using cmake config.

Fixes #39886

For newer Windows SDKs, the stdalign.h header is present, but the alignas macr is not
defined unless the compiler adds the std:c11 or newer.

Until we can set the std:c11 flag, work around the missing alignas macro using cmake config.
@ghost
Copy link

ghost commented Oct 2, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@Gnbrkm41
Copy link
Contributor

Gnbrkm41 commented Oct 3, 2020

I can confirm that this fixes the build failure with Windows Preview SDK for 20226. Thanks!

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sdmaclea sdmaclea merged commit 04031c3 into dotnet:master Oct 5, 2020
@sdmaclea sdmaclea deleted the libunwindStdalign branch October 5, 2020 16:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.cmd Clr+Libs with Insider Preview Windows SDK fails during builds of libunwind
4 participants