Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteExecutor FailureTest - NOT_FOR_MERGING #43211

Conversation

JimBobSquarePants
Copy link

Exists purely to test a potentially major issue I am seeing in RemoteExecutor from the dotnet/arcade repository where actions are not being invoked.

dotnet/arcade#6371

Didn't know of any other way to test this so sorry for hogging build infrastructure.

@antonfirsov antonfirsov added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Oct 9, 2020
@JimBobSquarePants
Copy link
Author

JimBobSquarePants commented Oct 9, 2020

Looks like the test is failing correctly here.

I can't tell here whether there are any failing tests on supported Windows environments.

@JimBobSquarePants
Copy link
Author

I created a standalone CI build just testing the executor.

Fails on Windows put Passes on Linux

https://github.com/JimBobSquarePants/RemoteExecutorTests

@stephentoub
Copy link
Member

@JimBobSquarePants, from dotnet/arcade#6371 it seems like the issue is now understood. Do you still need this PR open, or can it be closed? Thanks.

@JimBobSquarePants
Copy link
Author

Ah sorry @stephentoub yes this should be closed.

@stephentoub
Copy link
Member

Cool, thanks.

@JimBobSquarePants JimBobSquarePants deleted the JimBobSquarePants-RemoteExecutor-NoMerge branch October 22, 2020 15:17
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-installer NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants