-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace net6.0 TargetFramework Equality Conditions with msbuild intrinsic functions #43857
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer |
Are there any implications on not removing the platform part of the tfm from it and passing it down to the SDK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should instead use these intrinsic functions: dotnet/msbuild#5171 (comment).
There shouldnt be any, i have a blueprint which almost 90% of things going right. |
Not the SDK but one impact: we can finally revert dotnet/arcade@bd2a2b0 as we will then have distinct identities. That said, if |
We should also remove the
|
Yes we should do that as well (either in this PR or a follow-up one) but only for >= net5.0 configurations. For older ones we probably need to use EndsWith(...) or |
I will throw up follow up for this one. |
src/libraries/Microsoft.Win32.SystemEvents/src/Microsoft.Win32.SystemEvents.csproj
Outdated
Show resolved
Hide resolved
….SystemEvents.csproj Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update any docs with this? I would imagine people to still use '$(TargetFramework)' != '$(NetCoreAppCurrent)'
Which is fine as long as the TargetFramework isn't overloaded. There is room for improvement here as there are several projects that condition on |
Working Towards #43646
The
'$(TargetFramework)' == 'net6.0'
conditions are meant for all platforms. This currently works because we remove the platform string from the tfm.We will be no longer doing that hence we are changes the condition to $(TargetFramework.StartsWith('net6.0'))
I have done this for the
!=
as well.