Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0] Add backward compatibility file to timezone data compilation #43982

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

tqiu8
Copy link
Contributor

@tqiu8 tqiu8 commented Oct 28, 2020

backport of #43786 to release/5.0

/cc @tqiu8

Customer Impact

In some cases the browser ends up using older names for timezones. This adds back backward compatibility to timezone data, allowing the browser to find local timezones even with outdated ids. Applicable to all Argentina timezones. Fixes #43518.

Testing

Missing test cases were added into TimeZoneInfoTests. 2 tests were added to address this issue.

Risk

Low, fix is very small and easy to understand.

tqiu8 added 2 commits October 28, 2020 05:32
…otnet#43786)

* Add backward file from iana to handle backward compatibility in tz data
* add tests to check for backwards compatibility
@ghost
Copy link

ghost commented Oct 28, 2020

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

@lewing lewing added arch-wasm WebAssembly architecture Servicing-consider Issue for next servicing release review labels Oct 28, 2020
@lewing lewing added this to the 5.0.0 milestone Oct 29, 2020
@tqiu8 tqiu8 requested a review from marek-safar as a code owner October 29, 2020 19:14
@danmoseley danmoseley modified the milestones: 5.0.0, 5.0.x Nov 3, 2020
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Nov 21, 2020
@lewing
Copy link
Member

lewing commented Nov 21, 2020

Approved in tactics email.

@lewing lewing merged commit 9ecbcd7 into dotnet:release/5.0 Nov 21, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants