Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix #44443

jozkee · 2020-11-10T01:42:57Z

Fixes #28444

src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

…sh on Unix

src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs

src/mono/cmake/config.h.in

src/libraries/Native/Unix/System.Native/pal_io.c

stephentoub

Other than my FlushAsyncInternal comment, LGTM. Thanks.

ghost · 2020-11-11T03:37:40Z

Hello @jozkee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

jozkee added the area-System.IO label Nov 10, 2020

jozkee added this to the 6.0.0 milestone Nov 10, 2020

jozkee requested review from carlossanlop and stephentoub November 10, 2020 01:42

jozkee self-assigned this Nov 10, 2020

jozkee commented Nov 10, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs Show resolved Hide resolved

jozkee changed the title ~~Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync to behave like Flush on Unix~~ Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix Nov 10, 2020

jozkee requested a review from marek-safar as a code owner November 10, 2020 02:08

Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync to behave like Flu…

fef6a32

…sh on Unix

jozkee force-pushed the flush_fullfsync branch from 33bb376 to fef6a32 Compare November 10, 2020 02:12

carlossanlop reviewed Nov 10, 2020

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileStream.Unix.cs Show resolved Hide resolved

src/mono/cmake/config.h.in Outdated Show resolved Hide resolved

src/libraries/Native/Unix/System.Native/pal_io.c Outdated Show resolved Hide resolved

Remove HAVE_F_FULLFSYNC from mono/cmake/config.h.in

3cd548e

stephentoub approved these changes Nov 10, 2020

View reviewed changes

jozkee added 2 commits November 10, 2020 13:22

Address FlushAsyncInternal feedback

86752e5

Address feedback: use fcntl only for OSX

b5b979c

jozkee added the auto-merge label Nov 11, 2020

runfoapp bot mentioned this pull request Nov 11, 2020

Mono System.Text.Json.Tests on Windows timing out #42677

Open

ghost merged commit 4a8cddb into dotnet:master Nov 11, 2020

jozkee deleted the flush_fullfsync branch November 11, 2020 23:51

ghost locked as resolved and limited conversation to collaborators Dec 12, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix #44443

Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix #44443

jozkee commented Nov 10, 2020

stephentoub left a comment

ghost commented Nov 11, 2020

Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix #44443

Use fcntl(F_FLUSHFSYNC) on OSX and make FlushAsync() to behave like Flush(false) on Unix #44443

Conversation

jozkee commented Nov 10, 2020

stephentoub left a comment

Choose a reason for hiding this comment

ghost commented Nov 11, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.