Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NRE on EmitCalli #44452

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Fix NRE on EmitCalli #44452

merged 2 commits into from
Nov 19, 2020

Conversation

wzchua
Copy link
Contributor

@wzchua wzchua commented Nov 10, 2020

fixes #44421

jkotas
jkotas approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick turnaround!

@jkotas
Copy link
Member

jkotas commented Nov 10, 2020

cc @AndyAyersMS

@AndyAyersMS
Copy link
Member

Thanks, testing this now.

@AndyAyersMS
Copy link
Member

Works on my scenario.

@jkotas jkotas merged commit cb035a3 into dotnet:master Nov 19, 2020
@wzchua wzchua mentioned this pull request Nov 23, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
@wzchua wzchua deleted the fix/ref-emit-nre branch March 5, 2021 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
area-System.Reflection.Emit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ref emit broken for some calli cases?
4 participants
@wzchua @jkotas @AndyAyersMS @Dotnet-GitSync-Bot