Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Process test time #44593

Merged
1 commit merged into from
Nov 12, 2020
Merged

Reduce Process test time #44593

1 commit merged into from
Nov 12, 2020

Conversation

stephentoub
Copy link
Member

Fix a test that was taking 30 seconds, and make another test outerloop.

cc: @danmosemsft

Fix a test that was taking 30 seconds, and make another test outerloop.
@ghost
Copy link

ghost commented Nov 12, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.


Issue meta data
Issue content:
Fix a test that was taking 30 seconds, and make another test outerloop.

cc: @danmosemsft

</td>
Issue author: stephentoub
Assignees: -
Labels:
`area-System.Diagnostics.Process`

</td>
Milestone: -

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did I not think of doing it this way?

@ghost
Copy link

ghost commented Nov 12, 2020

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@danmoseley
Copy link
Member

danmoseley commented Nov 12, 2020

Strictly, it would be possible to implement p.Kill() such that it caused the wait (using method on the same process object) to complete (as tested here) but independently terminating the process (or allowing it to exit) did not. I guess that's what I was thinking.

@stephentoub
Copy link
Member Author

Strictly, it would be possible to implement p.Kill() such that it caused the wait (using method on the same process object) to complete (as tested here) but independently terminating the process (or allowing it to exit) did not. I guess that's what I was thinking.

If that was really a concern, Kill could be called on a Process.GetProcessById(p.Id) object. But I don't think it matters right now.

@danmoseley
Copy link
Member

Yes it's not worth more time.

@danmoseley
Copy link
Member

@steveisok two of the Android tests failed thus:

[16:20:16] dbug: Executing command: '/home/helixbot/work/9E7008EA/p/microsoft.dotnet.xharness.cli/1.0.0-prerelease.20559.2/runtimes/any/native/adb/linux/adb  start-server'
[16:20:16] dbug: 
[16:20:16] dbug: Executing command: '/home/helixbot/work/9E7008EA/p/microsoft.dotnet.xharness.cli/1.0.0-prerelease.20559.2/runtimes/any/native/adb/linux/adb  devices -l'
[16:20:16] dbug: Unexpected response from adb devices -l:
                 Exit code=0
                 Std. Output: List of devices attached

@danmoseley
Copy link
Member

FileSystemWatcher failure is already tracked by #24181

@ghost ghost merged commit 05ab615 into dotnet:master Nov 12, 2020
@stephentoub stephentoub deleted the processtesttime branch November 12, 2020 23:46
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants