-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Process test time #44593
Reduce Process test time #44593
Conversation
Fix a test that was taking 30 seconds, and make another test outerloop.
Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley Issue meta data
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did I not think of doing it this way?
Hello @danmosemsft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Strictly, it would be possible to implement p.Kill() such that it caused the wait (using method on the same process object) to complete (as tested here) but independently terminating the process (or allowing it to exit) did not. I guess that's what I was thinking. |
If that was really a concern, Kill could be called on a Process.GetProcessById(p.Id) object. But I don't think it matters right now. |
Yes it's not worth more time. |
@steveisok two of the Android tests failed thus:
|
FileSystemWatcher failure is already tracked by #24181 |
Fix a test that was taking 30 seconds, and make another test outerloop.
cc: @danmosemsft